Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/3502 trusted host fails with custom port #3556

Merged
merged 7 commits into from
Mar 7, 2019
Merged

bugfix/3502 trusted host fails with custom port #3556

merged 7 commits into from
Mar 7, 2019

Conversation

lbontecou
Copy link

@lbontecou lbontecou commented Feb 22, 2019

Thank you for contributing to Pipenv!

The issue

#3502

Pipfile Source


[[source]]
name = "my-pypi"
url = "https://${PYPI_USERNAME}:${PYPI_PASSWORD}@${PYPI_HOSTNAME}:${PYPI_PORT}/simple"
verify_ssl = false

Bug Identification


$ pipenv install --skip-lock --verbose
...
$ ['.../bin/pip', 'install', '--verbose', '--upgrade', '${PACKAGE_NAME}', '-i', 'https://${PYPI_USERNAME}:${PYPI_PASSWORD}@${PYPI_HOSTNAME}:${PYPI_PORT}/simple', '--trusted-host', '${PYPI_HOSTNAME}', '--extra-index-url', 'https://pypi.org/simple']

The fix

How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@techalchemy
Copy link
Member

Sorry for the delayed response, the changes look good to me, I'll merge them when they turn green! thanks for the pr

@techalchemy techalchemy added the PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge. label Mar 7, 2019
@techalchemy techalchemy added this to the March Release milestone Mar 7, 2019
@frostming frostming merged commit c52d06b into pypa:master Mar 7, 2019
@lbontecou lbontecou deleted the bugfix/3502-trusted-host-custom-port branch July 23, 2019 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants