Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing through safety args, to work around pyup unreliability #3877

Closed
wants to merge 2 commits into from
Closed

Conversation

lahwran
Copy link

@lahwran lahwran commented Jul 31, 2019

The issue

#2825

This issue has not been fully solved by the ability to provide a key - pyup sometimes goes down, and it usually takes a long time. Since pipenv check is the only would-be-fast way to test if a pipenv install is needed, this limits its usability.

The fix

This pull request adds a couple more arguments to pass through to safety, exposing its existing configuration options. It also adds an option to completely skip invoking safety, for cases were package installation checks and package security checks need to be run separately.

Because it's a trivial change, I also changed the return code to 2 on safety failure.

@lahwran lahwran closed this Aug 1, 2019
@lahwran
Copy link
Author

lahwran commented Aug 1, 2019

I was distracted when I wrote this and I both didn't write it very well and didn't notice. My bad! I'll leave it here as inspiration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant