Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly populate the system python path #4319

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Correctly populate the system python path #4319

merged 2 commits into from
Jun 5, 2020

Conversation

frostming
Copy link
Contributor

Thank you for contributing to Pipenv!

The issue

Close #4311, Close #4315

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@jandd
Copy link

jandd commented Jun 4, 2020

I think the python binary at least on Linux systems should be python3 if Python 3.x is used. If I just set the environment variable PIPENV_USE_SYSTEM=1 on a Python 3 only system with the current pipenv I still get an error because it tries to use /usr/bin/python which does not exist:

Installing dependencies from Pipfile.lock (63b55f)…
Failed to load paths: /bin/sh: /usr/bin/python: not found

I just added export PIPENV_USE_SYSTEM=1 to the Dockerfile mentioned in #4315 to test this.

@frostming
Copy link
Contributor Author

@jandd thanks for catching this, can you test with the latest changes?

@jandd
Copy link

jandd commented Jun 4, 2020

@frostming the applied patch set makes pipenv install --system --deploy work in the Alpine 3.12/Python 3.8 container

Copy link
Member

@techalchemy techalchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me... I was considering changing this behavior before the last release but I couldn't convince myself it was a good idea. Thanks for tackling it.

@frostming frostming merged commit 1a6e030 into master Jun 5, 2020
@frostming frostming deleted the bugfix/4315 branch June 5, 2020 02:11
jandd added a commit to jandd/devday_website that referenced this pull request Jun 10, 2020
A recent pipenv release introduced a regression that has been fixed in
pypa/pipenv#4319 this change pins the used
pipenv version to releases without that regression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants