Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipenv not properly entering remote shares. #4447

Closed
wants to merge 2 commits into from

Conversation

mlodybercik
Copy link

The issue

#4438

The fix

Look for letters in net use using win32net then change directory using drive letter instead of UNC path.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

Same thing as in issue.
Same thing as in issue.
@frostming
Copy link
Contributor

It seems win32net is provided by pywin32, and I am hesitating in introducing another 3rd party dependency. We should vendor it instead

@frostming frostming changed the title Fix #4438 Fix pipenv not properly entering remote shares. Aug 31, 2020
@frostming frostming linked an issue Aug 31, 2020 that may be closed by this pull request
@mlodybercik
Copy link
Author

We could spawn net use in a new cmd and parse those shares using raw text output.

@matteius
Copy link
Member

@mlodybercik I am not sure if this is still an issue or not -- if it persists today, we'd be interested in finding a solution. Sorry this went stale.

@matteius matteius closed this Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipenv shell not changing directory on Windows remote share
3 participants