Vendor in pip 22.1.2 #5166
Merged
Vendor in pip 22.1.2 #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
commented
Jul 7, 2022
| log("Using vendor dir: %s" % vendor_dir) | ||
| vendor(ctx, vendor_dir, package=package) | ||
| download_licenses(ctx, vendor_dir, package=package) | ||
| if type is None or type == "vendor": |
There was a problem hiding this comment.
This is a change I was making time and time again to the vendoring script to actually respect the argument being passed.
…aging and resolve differences in sourcing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor in pip 22.1.2 -- the latest pip. Also does:
Vendor in latest
requirementslibwhich has a fix for Annotated variables and rewriting imports of packaging library, as well as vendor in latestpip-shimswhich rewrites imports of packaging library.The net benefit is I was able to drop the vendor'd packaging and use the one from pip _internals across the board. Prior behavior is some things were using pip _internals packaging and some were using packaging that was installed in the virtualenv as a side-effect of creating the virtualenv.
The issue
Fixes #5147
The fix
By keeping pip updated in this project we maintain the latest fixes and have an easier time with future vendoring tasks.
The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.