Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra indexes #5220

Merged
merged 4 commits into from
Sep 7, 2022
Merged

Fix extra indexes #5220

merged 4 commits into from
Sep 7, 2022

Commits on Sep 6, 2022

  1. Improve type hints

    @aronbierbaum
    aronbierbaum committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    40350c6 View commit details
    Browse the repository at this point in the history

  2. Fix check if requirement's index name is in sources

    @aronbierbaum
    aronbierbaum committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    3dbd2bd View commit details
    Browse the repository at this point in the history

  3. Remove else clause that would always be triggered 

    The else clause of a for loop is executed unless a break statement is
executed to terminate the for loop.

https://docs.python.org/3/reference/compound_stmts.html#the-for-statement
    @aronbierbaum
    aronbierbaum committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    839a2d1 View commit details
    Browse the repository at this point in the history

  4. Fix test suite

    @aronbierbaum
    aronbierbaum committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    5edcec9 View commit details
    Browse the repository at this point in the history