pip install was skipping packages that were installed elsewhere #5255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oz123
approved these changes
Aug 14, 2022
| @@ -1529,7 +1526,7 @@ def pip_install( | |||
| ) | |||
|
|
|||
| pip_command = [ | |||
| project._which("python", allow_global=allow_global), | |||
There was a problem hiding this comment.
I wonder how many other issues this method causes... and there is also project.which... what a horror ...
matteius
changed the title
yeisonvargasf
pushed a commit
to yeisonvargasf/pipenv
that referenced
this pull request
Nov 19, 2022
* Fix for python not defaulting to the virtualenv during a pip install. Add --ignore-installed flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5254
The issue
Elsewhere we use
project_python(project)but in my testing I was able to reproduce #5254 and discovered it was skippingplatformdirsbecause it was already installed to my site-packages.