Scripts run package functions #5390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, should probably get an update to: https://pipenv.pypa.io/en/latest/advanced/#custom-script-shortcuts |
matteius
reviewed
Oct 7, 2022
oz123
approved these changes
Oct 8, 2022
|
@matteius can you please resolve the merge conflicts? |
|
@jerempy Hey -- looks like there is merge conflict with the named package categories work that got merged -- could you rebase? |
Can now add a callable like {call = "package.module:func('arg')"}
update to vendored tomlkit everywhere tests were breaking primarily due to the vendored tomlkit classes do not equal the non vendored
jerempy
force-pushed
the
Scripts-run-package-functions
branch
from
2749322
to
5f548d0
Compare
2 tasks
oz123
added a commit
that referenced
this pull request
Oct 17, 2022
Following #5390 I realized this code is duplicated into pipenv, and we can use that instead of the one in vistir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Requested new feature to add the ability to include something like:
#5294
The fix
This adds the ability to parse a callable with module.func in scripts
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.