Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression where wheel path is not included in the lockfile #5523

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Fix regression where wheel path is not included in the lockfile #5523

merged 4 commits into from
Dec 8, 2022

Conversation

matteius
Copy link
Member

@matteius matteius commented Dec 7, 2022

Thank you for contributing to Pipenv!

The issue

Fixes #5479

@matteius matteius requested a review from oz123 December 7, 2022 05:39
oz123
oz123 requested changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this to prevent future regressions?

@matteius matteius requested a review from oz123 December 8, 2022 01:34
@matteius matteius mentioned this pull request Dec 8, 2022
Closed
@oz123 oz123 merged commit 5a060e6 into main Dec 8, 2022
@oz123 oz123 deleted the issue-5479 branch December 8, 2022 07:32
@matteius matteius mentioned this pull request Dec 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oz123 oz123 oz123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install local wheel package missing path in lock file
2 participants
@matteius @oz123