Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace flake8 and isort with ruff #5643

Merged
merged 1 commit into from
Apr 13, 2023
Merged

feat: Replace flake8 and isort with ruff #5643

merged 1 commit into from
Apr 13, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 28, 2023

Thank you for contributing to Pipenv!

The issue

Continuation of #5361

Ruff supports over 500 lint rules and can be used to replace Flake8 (plus dozens of plugins), isort, pydocstyle, yesqa, eradicate, pyupgrade, and autoflake, all while executing (in Rust) tens or hundreds of times faster than any individual tool.

The fix

Added ruff in all the right places and removed flake8 and isort.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

Copy link
Member

@matteius matteius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I had not heard of ruff -- I assume because the test runner passed on windows that ruff works on windows too? I'm open to giving this a try.

@cclauss
Copy link
Contributor Author

cclauss commented Mar 28, 2023

Yes. Ruff is installed by pipx or pip and is multiplatform.

@oz123 oz123 merged commit 9525db4 into pypa:main Apr 13, 2023
@cclauss cclauss deleted the ruff branch April 13, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants