Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change that caused the credentials in source url issue #5882

Merged
merged 5 commits into from
Aug 28, 2023

Conversation

matteius
Copy link
Member

@matteius matteius commented Aug 28, 2023

Thank you for contributing to Pipenv!

The issue

Fixes #5878
Fixes #5880

The fix

Reverts the change that is believed to have caused this per #5878 (comment)

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius changed the title A hunch that this might fix the credentials in source url issue Revert change that broke the credentials in source url issue Aug 28, 2023
@matteius matteius changed the title Revert change that broke the credentials in source url issue Revert change that caused the credentials in source url issue Aug 28, 2023
@matteius matteius marked this pull request as ready for review August 28, 2023 23:00
@matteius matteius merged commit 413675f into main Aug 28, 2023
19 checks passed
@matteius matteius deleted the issue-5878 branch August 28, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2023.8.26 URL with auth not used correctly Injecting credentials broken
1 participant