Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check end of path for shell detection #6212

Closed
wants to merge 3 commits into from
Closed

Check end of path for shell detection #6212

wants to merge 3 commits into from

Commits on Jul 29, 2024

  1. Check end of path for shell detection 

    Addresses issue: pypa#6197

Previously these branches would trip if the shell name was present
anywhere in the cmd path. This updates the check to only look at the
end.
    @JoshStern
    JoshStern committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    f209213 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Add slash to cmd check

    @JoshStern
    JoshStern authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4229147 View commit details
    Browse the repository at this point in the history

  2. Add strict set of allowed shells 

    Updates the if else block to only allow an explicit set of shells instead of defaulting to the `activate` script.
    @JoshStern
    JoshStern authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f5eb923 View commit details
    Browse the repository at this point in the history