Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct for local package installs always being treated as editable. #6222

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Correct for local package installs always being treated as editable. #6222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d91d29
Correct for local package installs always being treated as editable.
matteius Aug 23, 2024
76bb77d
news fragment
matteius Aug 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/6222.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed regression where all local file installations were incorrectly treated as editable. Ensure that local file installations are explicitly marked as editable in both Pipfile and Pipfile.lock entries if editable installation is desired.
2 changes: 1 addition & 1 deletion pipenv/utils/dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def dependency_as_pip_install_line(
if not vcs:
for k in ["file", "path"]:
if k in dep:
if is_editable_path(dep[k]):
if dep.get("editable") and is_editable_path(dep[k]):
line.append("-e")
extras = ""
if "extras" in dep:
Expand Down
2 changes: 1 addition & 1 deletion pipenv/utils/requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def requirement_from_lockfile(
line = []
if k in package_info:
path = package_info[k]
if is_editable_path(path):
if package_info.get("editable") and is_editable_path(path):
line.append("-e")
line.append(f"{package_info[k]}")
if os_markers:
Expand Down
Loading