Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump changelog to 1.4.3 #1215

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

Gitznik
Copy link
Contributor

@Gitznik Gitznik commented Jan 16, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Bumped the changelog to 1.4.3, as the automated bump failed. @gaborbernat

Test plan

Tested by running

# command(s) to exercise these changes

@gaborbernat
Copy link
Contributor

Seems readthedocs failed with this 🤔

@Gitznik
Copy link
Contributor Author

Gitznik commented Jan 16, 2024

Seems readthedocs failed with this 🤔

Yeah looks like it does not like it if there's no news fragment. Will add a fix.

@Gitznik
Copy link
Contributor Author

Gitznik commented Jan 16, 2024

Seems readthedocs failed with this 🤔

Yeah looks like it does not like it if there's no news fragment. Will add a fix.

That fixed it. While looking at it I saw that the pipx inside pipx note doesn't seem to be rendered correctly. Is that expected?
image

@gaborbernat
Copy link
Contributor

Is that expected?

Sounds like a bug to me.

@chrysle
Copy link
Contributor

chrysle commented Jan 16, 2024

While looking at it I saw that the pipx inside pipx note doesn't seem to be rendered correctly. Is that expected?

Let's use the note admonition instead.

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gitznik
Copy link
Contributor Author

Gitznik commented Jan 16, 2024

While looking at it I saw that the pipx inside pipx note doesn't seem to be rendered correctly. Is that expected?

Let's use the note admonition instead.

It already uses that:

!!! warning
It is not recommended to install `pipx` via `pipx`. If you'd like to do this anyway, take a look at the
[`pipx-in-pipx`](https://github.com/mattsb42-meta/pipx-in-pipx) project and read about the limitations there.

@gaborbernat gaborbernat enabled auto-merge (squash) January 16, 2024 20:19
@gaborbernat gaborbernat merged commit f272651 into pypa:main Jan 16, 2024
12 checks passed
@chrysle
Copy link
Contributor

chrysle commented Jan 16, 2024

It already uses that:

Oh, we're talking about different documents, then. I meant the note on the front page. The one in installation.md renders correctly.

@gaborbernat
Copy link
Contributor

Yeah we should fix that but it sounds orthogonal to this pull request.

@Gitznik
Copy link
Contributor Author

Gitznik commented Jan 16, 2024

It already uses that:

Oh, we're talking about different documents, then. I meant the note on the front page. The one in installation.md renders correctly.

Shouldn't try to debug something while in a hurry. Thanks for clarifying. Will create a separate PR tomorrow 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants