-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codespell: config, workflow, pre-commit config and make it fix few typos #1219
Conversation
Thanks! Why did you add |
just what my https://github.com/yarikoptic/improveit/blob/main/codespellit does since not necessarily people have pre-commit as a service or a workflow ;) I will drop the commit adding github action now. |
856fe51
to
60c26c4
Compare
LGTM, please rebase or merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for suggesting this. Let's hope it will cut some manual effort in the future.
Have you run it on all current files?
Also - is it necessary to exclude the vens nox creates from checking when doing a run on all files?
yes, codespell considers all the applicable (non binary) files AFAIK. There is a commit done via
cool, adding |
60c26c4
to
f174839
Compare
pushed rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still waiting for codespell
to support .gitignore
files.
@yarikoptic Could you rebase again, please? |
for more information, see https://pre-commit.ci
=== Do not change lines below === { "chain": [], "cmd": "codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
Head branch was pushed to by a user without write access
af50f3f
to
299d48a
Compare
done. Also added to skip |
Thank you! I've taken the liberty to add a merge commit (there've been a lot of merges lately). |
changelog.d/
(if the patch affects the end users)it doesn't so I didn't bother
I see that once in a while commits fixing typos come in. With https://github.com/codespell-project/codespell you could minimize them even further since it would be harder for them to sneak in.