Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve home path in dir env vars #1241

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

Gitznik
Copy link
Contributor

@Gitznik Gitznik commented Feb 3, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Fixes #94. Implemented the original suggestion, which seems to perfectly fix the described problem.

Test plan

Tested by running

export PIPX_BIN_DIR="~/test"
pipx environment

->

Environment variables (set by user):

PIPX_HOME=
PIPX_BIN_DIR=~/test
PIPX_MAN_DIR=
PIPX_SHARED_LIBS=
PIPX_DEFAULT_PYTHON=
USE_EMOJI=

Derived values (computed by pipx):

PIPX_HOME=/home/robert/.local/pipx
PIPX_BIN_DIR=/home/robert/test
PIPX_MAN_DIR=/home/robert/.local/share/man
PIPX_SHARED_LIBS=/home/robert/.local/pipx/shared
PIPX_LOCAL_VENVS=/home/robert/.local/pipx/venvs
PIPX_LOG_DIR=/home/robert/.local/pipx/logs
PIPX_TRASH_DIR=/home/robert/.local/pipx/.trash
PIPX_VENV_CACHEDIR=/home/robert/.local/pipx/.cache
PIPX_DEFAULT_PYTHON=/home/robert/private/code/pipx/.nox/develop-3-12/bin/python
USE_EMOJI=true

@Gitznik Gitznik force-pushed the resolve_home_path_in_dir_env_vars branch from b9517b4 to 73f62a0 Compare February 3, 2024 22:57
dukecat0
dukecat0 previously approved these changes Feb 4, 2024
changelog.d/94.fix.md Outdated Show resolved Hide resolved
chrysle
chrysle previously approved these changes Feb 11, 2024
Copy link
Contributor

@chrysle chrysle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plead for disabling the review dismissal again.

@Gitznik Gitznik merged commit 7136b3d into pypa:main Feb 11, 2024
14 checks passed
@Gitznik
Copy link
Contributor Author

Gitznik commented Feb 11, 2024

I plead for disabling the review dismissal again.

No strong feelings here. I could've fumbled resolving the conflict I guess but I think that risk is quite small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Globbing for PIPX_BIN_DIR
3 participants