-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source interpreter to pipx metadata #1251
Add source interpreter to pipx metadata #1251
Conversation
FYI @chrysle and @alextremblay, it seems the standalone python downloaded on windows right now can't actually be executed. See the windows test workflow. I've added executing it to the test to validate this. Did you come across this in your tests @alextremblay? @chrysle for us this means we can't release this feature just yet. |
oh dear, that's unfortunate as i mentioned in the PR for standalone python, i don't have a windows machine to test with, and i don't have much experience developing python projects in windows maybe i can get a windows VM spun up for development or something... that might take me a few days |
Same here 👍 |
Great news. The |
Thanks for catching! You had a look at the source tarball, right? |
I actually setup a windows VM and tried it out there. |
Well, I'm all for my way of debugging ;-)
Will review shortly. |
Yeah that would've been probably the way more efficient approach 😅 ah well, now I have a windows VM for debugging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a newsfragment for the bugfix.
Thanks for the review.
Do you reckon we need a news fragment for the bugfix? The bug was never released, so it's not really a change for the user. Also what do you think about using the |
That's true, didn't think of it.
Well, the By the way, you'll need to update |
Co-authored-by: chrysle <fritzihab@posteo.de>
changelog.d/
(if the patch affects the end users)Summary of changes
I added the source interpreter of a venv to the pipx metadata in preparation of #1248 and #1249. We need this to be able to find out if a standalone interpreter is still being used.
I've done it this way following the logic of the
python_version
part of the pipx metadata. Is there any reason we don't use thepyvenv.cfg
for obtaining this information? It has the python version and the source interpreter in it, and it has been stable since python 3.3 AFAIK.I have not added a news fragment yet, as IMO this is part of #1243
Test plan
Tested by running