Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1270 Make dedup_ordered type annotations more specific #1271

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

sam-xif
Copy link
Contributor

@sam-xif sam-xif commented Feb 27, 2024

  • [ x ] I have added a news fragment under changelog.d/ (if the patch affects the end users)
    (patch does not affect end users)

Summary of changes

Parameter and return type annotations were made more specific for pipx.util.dedup_ordered as described in issue #1270.

Test plan

There are no functional changes to the code.

Copy link
Contributor

@chrysle chrysle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@chrysle chrysle enabled auto-merge (squash) March 1, 2024 13:43
@chrysle chrysle disabled auto-merge March 1, 2024 13:43
@chrysle chrysle enabled auto-merge (squash) March 1, 2024 13:43
@chrysle chrysle merged commit a8807a0 into pypa:main Mar 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opportunity for improvement of the type annotations of pipx.util.dedup_ordered
2 participants