Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH1229 Update how-pipx-works documentation to include pyproject.toml #1274

Merged
merged 11 commits into from
Mar 1, 2024
Merged

GH1229 Update how-pipx-works documentation to include pyproject.toml #1274

merged 11 commits into from
Mar 1, 2024

Conversation

IanHopkinson
Copy link
Contributor

This PR documents the use of pyproject.toml configuration files for use with pipx as per #1229

@IanHopkinson IanHopkinson mentioned this pull request Feb 29, 2024
Closed
@chrysle chrysle linked an issue Feb 29, 2024 that may be closed by this pull request
Update developing for pipx docs to include pyproject.toml #1229
Closed
chrysle
chrysle reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@chrysle chrysle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! I have a few suggestions, otherwise looks good.

docs/how-pipx-works.md Outdated Show resolved Hide resolved
docs/how-pipx-works.md Outdated Show resolved Hide resolved
docs/how-pipx-works.md Outdated Show resolved Hide resolved
docs/how-pipx-works.md Outdated Show resolved Hide resolved
IanHopkinson and others added 4 commits February 29, 2024 14:55
@IanHopkinson @chrysle
Update docs/how-pipx-works.md
d6672dc 
Co-authored-by: chrysle <fritzihab@posteo.de>
@IanHopkinson @chrysle
Update docs/how-pipx-works.md
d772f7e 
Co-authored-by: chrysle <fritzihab@posteo.de>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
1c1eda6 
for more information, see https://pre-commit.ci
@IanHopkinson @chrysle
Update docs/how-pipx-works.md
ea0cbff 
Co-authored-by: chrysle <fritzihab@posteo.de>
@chrysle
Copy link
Contributor

chrysle commented Feb 29, 2024

Ah, apparently MkDocs Material doesn't support footnotes out of the box. Could you configure that?

@IanHopkinson
Copy link
Contributor Author

@chrysle I also included the footnote extension in mkdocs.yml

chrysle
chrysle previously approved these changes Feb 29, 2024
View reviewed changes
Gitznik
Gitznik requested changes Feb 29, 2024
View reviewed changes
docs/how-pipx-works.md Outdated Show resolved Hide resolved
Gitznik
Gitznik approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@Gitznik Gitznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution 👍

@Gitznik Gitznik requested a review from chrysle March 1, 2024 08:21
@chrysle chrysle merged commit 78c568c into pypa:main Mar 1, 2024
14 checks passed
@chrysle
Copy link
Contributor

chrysle commented Mar 1, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gitznik Gitznik Gitznik approved these changes

@chrysle chrysle chrysle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update developing for pipx docs to include pyproject.toml
3 participants
@IanHopkinson @chrysle @Gitznik