Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repology shield to installation.md #1276

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

sstandre
Copy link
Contributor

@sstandre sstandre commented Mar 3, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

This PR adds a repology shield to README as per #234

It only includes pipx since python:pipx redirects to the former.

I used the Markdown syntax suggested in the issue, so the shield is left aligned. I can use the same syntax as the badges to center align it, if that is preferred.

Test plan

Tested by running

# command(s) to exercise these changes

Copy link
Contributor

@Gitznik Gitznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sstandre
Copy link
Contributor Author

sstandre commented Mar 4, 2024

Thanks for the review. I moved the shield to the Install pipx section, although I am unsure if it fits better above or below the warning:

  • Shield above warning
    pipx2
  • Shield below warning
    pipx1

Gitznik
Gitznik previously approved these changes Mar 4, 2024
Copy link
Contributor

@Gitznik Gitznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the shield above the warning is fine for me.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Jason Lam <meowmeowcat1211@gmail.com>
@dukecat0 dukecat0 changed the title Add repology shield to README Add repology shield to installation.md Mar 5, 2024
@chrysle chrysle linked an issue Mar 6, 2024 that may be closed by this pull request
@Gitznik Gitznik merged commit f3b4abc into pypa:main Mar 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add repology shield to README
3 participants