Update Instructions for zsh in pipx completions Output
#1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dukecat0
requested changes
Mar 21, 2024
chrysle
reviewed
Mar 21, 2024
Co-authored-by: chrysle <fritzihab@posteo.de>
chrysle
reviewed
Mar 21, 2024
Co-authored-by: chrysle <fritzihab@posteo.de>
for more information, see https://pre-commit.ci
chrysle
previously approved these changes
Mar 21, 2024
Gitznik
previously approved these changes
Mar 22, 2024
dukecat0
requested changes
Mar 22, 2024
Co-authored-by: Jason Lam <meowmeowcat1211@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.d/(if the patch affects the end users)(Note: change does not affect usage by users, so I haven't added to
changelog.d/)Summary of changes
The output of
pipx completions([constants.py](https://github.com/pypa/pipx/blob/master/src/pipx/constants.py#L39):39) has been modified to reflect the current capability ofargcompleteas of v3 (changelog), namely that zsh is fully supported, so there is no need forbashcompinit. However,argcomplete< v3 is accounted for by referencing the former workflow.Additionally, I've added to the top of the output to indicate that one must first install
argcomplete, if not already installed or if using zipapp. This is due to the fact that, in setting up completions for myself, I had to first installargcomplete, and am running zsh on macOS 14.4.Test plan
N/A