feat: support Python version for --python arg when py launcher is n…
#1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huxuan
force-pushed
the
xuan.hu/find_command_python
branch
2 times, most recently
from
f985999
to
82e9664
Compare
huxuan
force-pushed
the
xuan.hu/find_command_python
branch
from
82e9664
to
1327a20
Compare
chrysle
reviewed
Apr 18, 2024
huxuan
force-pushed
the
xuan.hu/find_command_python
branch
2 times, most recently
from
56ced5d
to
ec3f705
Compare
chrysle
reviewed
Apr 22, 2024
huxuan
force-pushed
the
xuan.hu/find_command_python
branch
from
e721cc4
to
b2ee495
Compare
chrysle
reviewed
Apr 23, 2024
huxuan
force-pushed
the
xuan.hu/find_command_python
branch
2 times, most recently
from
83945ef
to
2903daa
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: chrysle <fritzihab@posteo.de>
Co-authored-by: chrysle <fritzihab@posteo.de>
for more information, see https://pre-commit.ci
Co-authored-by: chrysle <fritzihab@posteo.de>
huxuan
force-pushed
the
xuan.hu/find_command_python
branch
from
2903daa
to
a2d98c3
Compare
chrysle
approved these changes
Apr 26, 2024
dukecat0
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ot available
changelog.d/(if the patch affects the end users)Summary of changes
Close #1342
find_python_command()to find python command according to provided python version.pipx installandfind_python_interpreter().Test plan
Tested by running
BTW, I am a little confused about the fixture
pipx_temp_env, seemsshutil.which(python_command)will always return empty result when it is enabled. So I removed it in some related test cases. Please help me to double confirm whether it is used as expected.