refactor: unify batch behavior of "install-all", "reinstall-all" and "upgrade-all" #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
huxuan
force-pushed
the
xuan.hu/unify-all-logic
branch
from
ad1c0f7
to
d60b05d
Compare
huxuan
changed the title
-all operation logic
huxuan
force-pushed
the
xuan.hu/unify-all-logic
branch
from
ff3543f
to
34212ed
Compare
dukecat0
reviewed
Apr 21, 2024
huxuan
force-pushed
the
xuan.hu/unify-all-logic
branch
from
34212ed
to
e354c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.d/(if the patch affects the end users)No changelog provided since it is refactor.
Summary of changes
Per the discussion here #1348 (comment), this pull request unified the batch behavior of
install-all,reinstall-allandupgrade-all.Note that
uninstall-allis not included in this pull request since the logic is totally different from others. I would suggest to use a separate pull request foruninstall-alljust like #1348 since the behavior is totally changed.Test plan
Tested by running
P.S. Mark it as draft as depends on #1348