Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move --global option into shared parser #1397

Merged
merged 4 commits into from
May 11, 2024

Conversation

dukecat0
Copy link
Member

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Move --global option into shared parser, such that it can be passed after the subcommand, for example pipx ensurepath --global.

Test plan

Tested by running

pipx install --global nox
pipx ensurepath --global

chrysle
chrysle previously approved these changes May 11, 2024
@dukecat0 dukecat0 merged commit 964d93c into pypa:main May 11, 2024
14 checks passed
@dukecat0 dukecat0 deleted the mv-global-to-shared branch May 11, 2024 14:09
@Paiusco
Copy link
Contributor

Paiusco commented May 11, 2024

Dumb question:
will it still accept pipx --global ensurepath?

If not, then --help is misleading now IMO.

If both positions are accepted, then forget what I've said

@dukecat0
Copy link
Member Author

Yes, both positions are accepted.

DimitriPapadopoulos pushed a commit to DimitriPapadopoulos/pipx that referenced this pull request May 12, 2024
* Move `--global` option into shared parser

* Add changelog

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update tests

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
DimitriPapadopoulos pushed a commit to DimitriPapadopoulos/pipx that referenced this pull request May 12, 2024
* Move `--global` option into shared parser

* Add changelog

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update tests

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants