-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply ruff/flake8-implicit-str-concat rule ISC001 #1403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
ISC001
branch
2 times, most recently
from
May 12, 2024 12:26
b310745
to
23e8803
Compare
DimitriPapadopoulos
force-pushed
the
ISC001
branch
3 times, most recently
from
May 13, 2024 09:31
6868972
to
4769ebb
Compare
gaborbernat
previously approved these changes
May 13, 2024
auto-merge was automatically disabled
May 13, 2024 19:47
Head branch was pushed to by a user without write access
DimitriPapadopoulos
force-pushed
the
ISC001
branch
from
May 13, 2024 19:47
0a1f5ef
to
7331c8d
Compare
I had to rebase. |
gaborbernat
approved these changes
May 13, 2024
gaborbernat
previously approved these changes
May 13, 2024
uranusjr
reviewed
May 14, 2024
uranusjr
previously approved these changes
May 14, 2024
huxuan
reviewed
May 14, 2024
auto-merge was automatically disabled
May 14, 2024 05:37
Head branch was pushed to by a user without write access
DimitriPapadopoulos
force-pushed
the
ISC001
branch
from
May 14, 2024 05:37
ec5b747
to
1487527
Compare
huxuan
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.d/
(if the patch affects the end users)Summary of changes
Apply ruff/flake8-implicit-str-concat rule
ISC001
Fixes #1402 .
Test plan
Tested by running