Use multiple machine suffixes for standalone python #1462
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.d/
(if the patch affects the end users)Summary of changes
With the release of Yen v0.5,
pipx
andyen
are officially rivals (; But since it's very easy to port my bug fixes topipx
, I decided to do just that.For now, this change only adds 1 new suffix compared to the previous logic:
x86_64-unknown-linux-gnu
, as a user reported this problem: tusharsadhwani/yen#17python-build-standalone
ships various tiers ofunkown-linux-gnu
python builds. fromv1
tov4
.v4
is highly CPU specific and requires modern CPU features, only available on higher end desktop chips starting from early 2010s.I defaulted to
v3
for a compromise of good speed, and good compatibility with most machines. But in the more recent releases,v3
no longer shipspython3.8
wheels. Having a fallback to thev1
machine suffix would fix this problem.Test plan
On a Linux machine, this would fail on main branch (as 3.8 is not available in for
x86_64-v3-unknown-linux-gnu
.But with the current change it will work, as it is available in
x86_64-unknown-linux-gnu
variant.