Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.15.1.1 #324

Merged
merged 3 commits into from
Jan 8, 2020
Merged

0.15.1.1 #324

merged 3 commits into from
Jan 8, 2020

Conversation

itsayellow
Copy link
Contributor

Published to pypi.

@itsayellow
Copy link
Contributor Author

itsayellow commented Jan 7, 2020

Publishing to PyPI seemed to work fine.

However, I think nox -s publish_docs published to MY github account pages https://itsayellow.github.io/pipx/

carvel:pipx /Users/mclapp/Library/Python/3.7/bin/nox -s publish_docs
nox > Running session publish_docs
nox > Creating virtual environment (virtualenv) using python3.7 in .nox/publish_docs
nox > pip install . jinja2 mkdocs mkdocs-material
nox > python generate_docs.py
nox > mkdocs gh-deploy
INFO    -  Cleaning site directory 
INFO    -  Building documentation to directory: /Users/mclapp/git/pipx/site 
WARNING -  Version check skipped: No version specificed in previous deployment. 
INFO    -  Copying '/Users/mclapp/git/pipx/site' to 'gh-pages' branch and pushing to GitHub. 
INFO    -  Your documentation should shortly be available at: https://itsayellow.github.io/pipx/ 
nox > Session publish_docs was successful.

@itsayellow itsayellow requested a review from cs01 January 7, 2020 05:15
@itsayellow
Copy link
Contributor Author

Also it looks like previous edits to the Contributing page haven't showed up on https://pipxproject.github.io/pipx/contributing/

Copy link
Member

@cs01 cs01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have to update the noxfile to explicitly pass the mkdocs config to the publish command

mkdocs gh-deploy -f mkdocs.yml

@itsayellow itsayellow merged commit fea5c94 into pypa:master Jan 8, 2020
@itsayellow
Copy link
Contributor Author

itsayellow commented Jan 8, 2020

So to publish everything from pipxproject/pipx from master, I assume that requires special permissions that I don't have? Or is there some way I have access to pipxproject/pipx ?

@itsayellow itsayellow deleted the 0.15.1.1 branch January 8, 2020 04:34
@cs01
Copy link
Member

cs01 commented Jan 8, 2020

The docs are served from the gh-pages branch, which you may have access to commit to directly.

@itsayellow
Copy link
Contributor Author

Can you add a release? I don't think I'm able to do that.

@cs01
Copy link
Member

cs01 commented Jan 8, 2020

Sure, what was the commit you uploaded to PyPI?

@itsayellow
Copy link
Contributor Author

Basically the last commit of this PR was what I uploaded to PyPI.

@itsayellow
Copy link
Contributor Author

I think I just fixed the docs on https://pipxproject.github.io/pipx/ .

What I did was make my gh-pages branch track upstream/gh-pages and then ran

nox -s docs
nox -s publish_docs

I think the docs are updated properly now on https://pipxproject.github.io/pipx/

Let me know if that is improper or wrong.

@itsayellow
Copy link
Contributor Author

I think I just fixed the docs on https://pipxproject.github.io/pipx/ .

Actually it appears that I'm not allowed to push to pipxproject/pipx.git, so I did not update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants