Fix show/hide cursor for older Windows #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
approved these changes
Jan 28, 2021
itsayellow
added a commit
to itsayellow/pipx
that referenced
this pull request
Feb 16, 2021
Add app_name "pipx" to ensurepath comments, don't duplicate bin_paths. Apply typing.NoReturn to code base (pypa#605) Fix post-release development versioning (pypa#601) Make constants.py single source for WINDOWS boolean. (pypa#607) Add section on where pipx keeps its logs. (pypa#608) Upgrade all pre-commit plugins except black. (pypa#611) Fix show/hide cursor for older Windows (pypa#610) Drop .exe appending on Windows (pypa#606) This makes Venv.run_app() and code path along it accept an additional argument, so we can distinguish between the "real" name (filename) of an app, and the name supplied by the user. This makes the code simpler, espacially when dealing with the proposed [pipx.run] entry points. Add text color capability for Windows (pypa#612) Better Unicode / emoji capability detection (pypa#614) Use python 3.9 as default python for CI. (pypa#622) Don't show / hide cursor if not in tty. (pypa#620)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdSummary of changes
Closes #603 .
On Windows, this PR adds and uses the method of showing/hiding the cursor outlined in https://stackoverflow.com/a/10455937
Test plan
I don't have an older copy of Windows, so if somebody could test this with an old Windows (before Windows 10 TH2 (v1511)) I would be much appreciative.
From #603, all one would need to do would be to see if there are visible ANSI escape codes printed (e.g.
[?25l,[?25h) when executing pipx commands like: