Prevent pipx from erroneously listing other apps installed outside of pipx #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsayellow
changed the title
pdecat
reviewed
Apr 10, 2021
| @@ -238,7 +241,7 @@ def _get_exposed_app_paths_for_package( | |||
| # Windows, we use a less strict check if we don't have a symlink. | |||
| if _can_symlink(local_bin_dir) and b.is_symlink(): | |||
| is_same_file = b.resolve().parent.samefile(venv_bin_path) | |||
| else: | |||
| elif not _can_symlink(local_bin_dir): | |||
There was a problem hiding this comment.
This breaks the test below:
pipx install py-spy
...
Traceback (most recent call last):
File "/home/patrick/.local/bin/pipx", line 8, in <module>
sys.exit(cli())
File "/home/patrick/.local/lib/python3.9/site-packages/pipx/main.py", line 762, in cli
return run_pipx_command(parsed_pipx_args)
File "/home/patrick/.local/lib/python3.9/site-packages/pipx/main.py", line 193, in run_pipx_command
return commands.install(
File "/home/patrick/.local/lib/python3.9/site-packages/pipx/commands/install.py", line 69, in install
run_post_install_actions(
File "/home/patrick/.local/lib/python3.9/site-packages/pipx/commands/common.py", line 377, in run_post_install_actions
package_summary, _ = get_venv_summary(
File "/home/patrick/.local/lib/python3.9/site-packages/pipx/commands/common.py", line 201, in get_venv_summary
exposed_app_paths = _get_exposed_app_paths_for_package(
File "/home/patrick/.local/lib/python3.9/site-packages/pipx/commands/common.py", line 249, in _get_exposed_app_paths_for_package
if is_same_file:
UnboundLocalError: local variable 'is_same_file' referenced before assignment
Using current master https://github.com/pipxproject/pipx/blame/13b6a271fcddad00cad6eab82fc2714cf6ad4503/src/pipx/commands/common.py#L249
This was referenced Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdSummary of changes
Closes #564, #548.
This fixes some code goofs that allowed pipx to proclaim that pre-existing binaries in
~/.local/binwere part of a pipx install when they were in fact installed previously usingpip install --user.First fix is not to search for apps of dependencies if we didn't include dependencies on install.
Second fix is to fall back to checking non-symlinks only on non-symlink systems. Previously we would check non-symlinks always if we encountered a file that was not a symlink, which was not the intent of the if statement.
Test plan
Tested by running:
pipx should only list the app 'twine' associated with venv 'twine'. 'keyring' is a dependency and should not be listed.
This PR:
pipx 0.16.1.0