Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: same interpreter from venv to get pkg name #957

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

lecardozo
Copy link
Contributor

@lecardozo lecardozo commented Mar 18, 2023

  • I have added an entry to docs/changelog.md

Summary of changes

Fixes #956

  • Use venv-specific interpreter for package name extraction when injecting local "pip-installable" packages

Test plan

Tested by running the following locally

pipx install jupyterlab --python python3.8

# The package must be any wheel with interpreter constraints
# that are compatible with the venv's in which it's going to be injected
# but doesn't match pipx's default interpreter
pipx inject jupyterlab package-1.0.0-py3-none-any.whl

@lecardozo lecardozo marked this pull request as ready for review March 18, 2023 22:27
@dukecat0 dukecat0 merged commit 2d713f5 into pypa:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inject command uses wrong python interpreter for local packages
4 participants