Resolve mypy type annotation issues in CI #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failures were: ``` readme_renderer/rst.py:26: error: Unused "type: ignore" comment [unused-ignore] readme_renderer/rst.py:33: error: Argument 1 of "emptytag" is incompatible with supertype "docutils.writers._html_base.HTMLTranslator"; supertype defines the argument type as "Element" [override] readme_renderer/rst.py:33: note: This violates the Liskov substitution principle readme_renderer/rst.py:33: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides ``` The CI failures appear to be related to an updated release of `types-docutils`.
Contributor
Author
|
Well...shoot fire. The mypy tests now pass, but an unrelated issue has cropped up, and as with the mypy failures, the new issues are occurring in |
Merged
miketheman
approved these changes
Oct 9, 2025
Member
miketheman
left a comment
miketheman
left a comment
There was a problem hiding this comment.
I've confirmed locally that when combined with the test changes, everything passes to green.
In order to merge the two PRs, I'll override the allowance for the project to force this through, to be quickly followed by the test changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent example of a mypy CI failure:
The CI failures appear to be related to an updated release of
types-docutils.