-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generated _version.py contains invalid type annotations on <3.9 #912
Labels
Comments
( Might be worth making sure to have a blank line under the
|
i wonder if this ought to be a mypy bug as well, i was under the impression the future import was just to stop evaluating, the comments aren't evaluated to begin with i'll add the future import back |
RonnyPfannschmidt
added a commit
that referenced
this issue
Sep 20, 2023
…te-type-annotations fix #912 - ensure mypy safe version template
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello! Thank you for all of the work on this package ❤️
I wanted to flag up that since
setuptools_scm==8.0.1
, the dynamically generated version file contains type hints that are only valid on python>=3.9
Unless specifically excluding the version file from type checking, I imagine that this is very likely to lead to broken CI/CD pipelines in most workflows.
I think that removing the inline type annotations from the version file (like in
setuptools_scm<8.0.0
) or adding afrom __future__ import annotations
at the top of the file would solve the problemThe text was updated successfully, but these errors were encountered: