Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on windows, path comparison should be case-insensitive #993

Closed
ThomasWaldmann opened this issue Dec 24, 2023 · 1 comment
Closed

on windows, path comparison should be case-insensitive #993

ThomasWaldmann opened this issue Dec 24, 2023 · 1 comment
Labels
bug

Comments

@ThomasWaldmann
Copy link

Just seen that on github CI (windows / msys2 based part), using the latest setuptools_scm:

WARNING setuptools_scm._file_finders.git toplevel mismatch computed d:/a/borg/borg vs resolved D:/a/borg/borg
@RonnyPfannschmidt
Copy link
Contributor

@ThomasWaldmann seems like we are hitting python/cpython#84548

i'll investigate a workaround

RonnyPfannschmidt added a commit to RonnyPfannschmidt/setuptools_scm that referenced this issue Jan 8, 2024
@RonnyPfannschmidt
begin to address pypa#993 - add normcase
aeeeac6 
normcase around realpath all over the place should help to operate with normalized paths in general
RonnyPfannschmidt added a commit to RonnyPfannschmidt/setuptools_scm that referenced this issue Jan 8, 2024
@RonnyPfannschmidt
begin to address pypa#993 - add normcase
21125a8 
normcase around realpath all over the place should help to operate with normalized paths in general
RonnyPfannschmidt added a commit to RonnyPfannschmidt/setuptools_scm that referenced this issue Jan 8, 2024
@RonnyPfannschmidt
wip: fix pypa#993 and add a test - needs testrun on windows
1ae2ec1
RonnyPfannschmidt added a commit to RonnyPfannschmidt/setuptools_scm that referenced this issue Jan 8, 2024
@RonnyPfannschmidt
fix pypa#993 and add a test
9af3ba4
RonnyPfannschmidt added a commit to RonnyPfannschmidt/setuptools_scm that referenced this issue Feb 13, 2024
@RonnyPfannschmidt
begin to address pypa#993 - add normcase
027a52d 
normcase around realpath all over the place should help to operate with normalized paths in general
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RonnyPfannschmidt @ThomasWaldmann