listing git files failed on git repo #997
Comments
|
I've replicated the issue in a Linux Docker container as well, so the issue isn't peculiar to my environment. Curiously, even though I'm seeing these errors when running builds, I'm finding that files are being included that would seem to depend on git metadata, such as Lorem ipsum.txt in jaraco.text. Oh. I think I see what's happening now. |
|
Aha. So I've clarified my confusion. The errors are expected to be emitted. They just need not to appear during the sdist phase. The reason there were issues with the distutils build was not because of scm file finders, but because of an exclude directive. The error from setuptools_scm was a red herring. |
|
@jaraco , sorry but your last two comments are a little too technical for me to understand. I get this same error every time I do a build even though the build seems successful. How can I get rid of that error message? |
|
Because of the way setuptools is engineered, it will necessarily involve I'll move this issue to packaging-problems for consideration. |
|
Thanks for your reply. The message reports a big fat ERROR, not even a warning so I assumed I must have a mistake somewhere and have spent ages trying different fixes which did not change anything. It is disconcerting to see that ERROR reported so this clearly must be considered a bug. |
|
Is there anything we can to do avoid this message or the only option is to attempt to switch to another packaging alternative? Clearly the linked packaging issue seems to claim is a setuptools issue and not generic packaging one. To my surprise i seen two that updated their scm to 8 to get rid of if, but that does not seem to be the case. |
|
The error only ought to happen when git is detected but breaks horribly We might be able to narrow it down better if the file finder hooks received more than a path Unfortunately they don't so there's situations with false positives outweigh ing the rwst atm |
|
I just took a look again, theres a bug in finding the git top level that's in need of a fix |
|
Yes, I it is always a shame to hear about errors like this -> I also spent a couple of days to understand the build system and get rid of this error message. But the solution is pretty simple - to split the builds:
And that's it. For me it sounds weird that running 2 builds together works like (I mean this is a real huge bug):
|
|
@michalnik actually, a one-line |
While troubleshooting pypa/distutils#224, I've stumbled onto another issue.
I'm running
pyproject-build .on a number of projects, and in the output, I see the following warning for both sdist and wheel generation:This is happening across multiple projects I develop.
If I install the build requirements locally and run
py -m build --no-isolation .and put a breakpoint in thesetuptools_scm._file_finders.git:_git_toplevel, I see that when the error occurs, the git command is being run against a copy of the source that doesn't include the git directory. Something about the build ecosystem is causing the .git directory that I clearly cloned not to be included in the build. I tried running with some older versions of build going back to 0.9, but that didn't seem to make a difference.So far, I've only replicated this on my own system. I'd test in an isolated environment, but I don't have ready access to Docker at the moment. I'll test again after restoring Docker.
The text was updated successfully, but these errors were encountered: