Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ruff from 0.3.4 to 0.9.1 #1096

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Bump ruff from 0.3.4 to 0.9.1 #1096

wants to merge 8 commits into from

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

RonnyPfannschmidt
RonnyPfannschmidt requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks starting to address this

For the pytest rules we should use tje modern one after the maintainers of flake8-pytest went through the trouble of changing their default after i asked them to

pyproject.toml Outdated Show resolved Hide resolved
@DimitriPapadopoulos
pre-commit autoupdate (ruff)
90ea3d0 
* The linter should not fix by default.
  The --fix option is passed by pre-commit.
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the ruff_0.9.1 branch 2 times, most recently from 382294d to 7c2e0de Compare January 15, 2025 21:02
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Jan 16, 2025
Draft
@DimitriPapadopoulos
Apply ruff/flake8-pyi rule PYI006
b46b99e 
PYI006 Use `<` or `>=` for `sys.version_info` comparisons
@DimitriPapadopoulos
Apply ruff rule RUF036
31060f8 
RUF036 `None` not at the end of the type annotation.
@DimitriPapadopoulos
Apply ruff rule RUF043
ecd7491 
RUF043 Pattern passed to `match=` contains metacharacters but is neither escaped nor raw
@DimitriPapadopoulos
Apply ruff rule RUF052
2e6bbd2 
RUF052 Local dummy variable is accessed
@DimitriPapadopoulos
Run ruff format
e8c488f
@DimitriPapadopoulos
Apply ruff/flake8-pytest-style rule PT001
febd01c 
PT001 Use `@pytest.fixture` over `@pytest.fixture()`
@DimitriPapadopoulos
Apply ruff/flake8-pytest-style rule PT023
2d43b14 
PT023 Use `@pytest.mark.skip_commit` over `@pytest.mark.skip_commit()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @RonnyPfannschmidt