-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bdist_wheel misbehaves on Windows newlines #1126
Comments
I discovered this on msabramo/setuptools-markdown#11. |
I have a similar problem, but only in py3. When I build with py27 the complete string is included. See JessicaTegner/pypandoc#147 |
I worked on this a bit today, but ended up running up against #1196 and pypa/wheel#206. The thing I'm after - where are the lines being stripped? It should be possible by tracing a dist_info invocation on the setup.py presented above to ascertain where the failure lies. |
I traced this into wheel and then figured it would be easier to patch downstream. |
This can be closed now, yes? |
@agronholm I still experience the problem. Xoviat says the problem has been traced into "wheel", but I don't see an open issue, or reference to the offending piece of code. I would not rather close this until the problem is fixed, or a new issue is created. |
Why not open an issue against wheel then? Provide instructions to reproduce and I'll fix it. |
I haven't opened an issue against wheel because I don't know if it's a wheel problem or not. The only indication I have is the comment above, from a deleted account, made in 2017. I've also implemented my own workaround (manually removing Windows linebreaks), so feel free to take ownership of the issue. |
I can't reproduce this on Linux. Will try again with Windows 10. |
Environment
Python 3.6 64 bits, Windows 10.
Steps to reproduce
setup.py
Observed behavior
dist\package-0.0.0-py3-none-any.whl\package-0.0.0.dist-info\METADATA
Expected behavior
METADATA
should include"second line"
, or an error raised during build.Notes
python setup.py sdist
generates a file with both lines correctly in thedescription
field ofPKG-INFO
, but they maintain their'\r\n'
line endings while the rest of the file uses only\n
. This is very unusual and should probably be changed or warned against.I'm not sure if this issue should be reported here or in https://github.com/pypa/wheel, so apologies if I'm in the wrong place.
The text was updated successfully, but these errors were encountered: