-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API to customise file downloading #149
Comments
This might be a major security issue as files might be downloaded from untrusted sources, without the user's consent, especially in automated build environments. I strongly object to such a feature unless it can be made secure, especially in a headless, automated build environment. |
I don't think allowing people to do insecure things is the same as a security issue, but regardless of that, I believe that |
Hello, I think we can safely close this issue, right?
If anyone would like to revisit this topic with more information or a specific use case, please feel free to post a comment bellow so we can re-open the issue if necessary. |
Originally reported by: wichert (Bitbucket: wichert, GitHub: wichert)
There are valid reasons for customising how URLs are loaded. For example lovely.buildouthttp does this to support authentication for private servers. zc.buildoutsftp has a similar need.
Since setuptools does not expose an API for this those tools try to do this by replacing the URL opener setuptools uses, but this is fragile and causes breakage when setuptools internals change. Ticket #61 is an example of this. It would be useful if setuptools had an API that makes it possible to hook into the URL downloading process to make this more flexible.
The text was updated successfully, but these errors were encountered: