Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to customise file downloading #149

Closed
ghost opened this issue Feb 10, 2014 · 3 comments
Closed

API to customise file downloading #149

ghost opened this issue Feb 10, 2014 · 3 comments
Labels
enhancement major Needs Triage Issues that need to be evaluated for severity and status.

Comments

@ghost
Copy link

ghost commented Feb 10, 2014

Originally reported by: wichert (Bitbucket: wichert, GitHub: wichert)


There are valid reasons for customising how URLs are loaded. For example lovely.buildouthttp does this to support authentication for private servers. zc.buildoutsftp has a similar need.

Since setuptools does not expose an API for this those tools try to do this by replacing the URL opener setuptools uses, but this is fragile and causes breakage when setuptools internals change. Ticket #61 is an example of this. It would be useful if setuptools had an API that makes it possible to hook into the URL downloading process to make this more flexible.


@silkentrance
Copy link
Contributor

silkentrance commented Jul 11, 2018

This might be a major security issue as files might be downloaded from untrusted sources, without the user's consent, especially in automated build environments.

I strongly object to such a feature unless it can be made secure, especially in a headless, automated build environment.

@pganssle
Copy link
Member

I don't think allowing people to do insecure things is the same as a security issue, but regardless of that, I believe that easy_install is the only part of setuptools that hits the internet, and it's deprecated in favor of pip, so I don't think there's any reason to do this.

@pganssle pganssle added the Needs Triage Issues that need to be evaluated for severity and status. label Oct 19, 2018
@abravalheri
Copy link
Contributor

Hello, I think we can safely close this issue, right?

easy_install has been deprecated for a while now and vastly replaced by pip (and the internal mechanisms pypa/build uses to bootstrap the isolated build environment).

If anyone would like to revisit this topic with more information or a specific use case, please feel free to post a comment bellow so we can re-open the issue if necessary.

jaraco added a commit that referenced this issue Jun 12, 2022
jaraco pushed a commit that referenced this issue Jun 28, 2024
Automated formatting runs such as #149 / ab77f7d left over these extra quotes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement major Needs Triage Issues that need to be evaluated for severity and status.
Projects
None yet
Development

No branches or pull requests

3 participants