Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py encoding #191

Closed
ghost opened this issue Apr 16, 2014 · 4 comments
Closed

setup.py encoding #191

ghost opened this issue Apr 16, 2014 · 4 comments

Comments

@ghost
Copy link

ghost commented Apr 16, 2014

Originally reported by: philip_thiem (Bitbucket: philip_thiem, GitHub: Unknown)


In compat.py:55 may choke if the setup.py is not compatible with the expected console (filesystem?) encoding when compile tries to read from the file object with unspecified encoding.

For example: wincertstore appears to have a BOM at the beginning of its setup.py
but on windows something is defaulting to cp932. Yielding:

UnicodeDecodeError: 'cp932' codec can't decode byte 0xef in position 0: illegal multibyte sequence

exec(compile(source, fn, 'exec'), globs, locs)

Produced doing: setup.py test


@ghost
Copy link
Author

ghost commented Apr 16, 2014

Original comment by philip_thiem (Bitbucket: philip_thiem, GitHub: Unknown):


Actually this might be failing in in the package scripts... will take a closer look.

@ghost
Copy link
Author

ghost commented Apr 16, 2014

Original comment by philip_thiem (Bitbucket: philip_thiem, GitHub: Unknown):


It fails during the setup.py loading (executing)... Specifically when setup.py is trying to read CHANGES.txt. upstream bug? The CHANGES.txt has the 0xfe at position zero which is being misread because the encoding isn't specified. m-time is 2-26-2014

@ghost
Copy link
Author

ghost commented Apr 16, 2014

Original comment by philip_thiem (Bitbucket: philip_thiem, GitHub: Unknown):


https://bitbucket.org/tiran/wincertstore/pull-request/3/read-readmetxt-and-changestxt-as-utf-8/diff

Sent a pull request to upstream, they don't have an issue tracker, if it doesn't get noticed, I can email.

@ghost
Copy link
Author

ghost commented May 18, 2014

Original comment by philip_thiem (Bitbucket: philip_thiem, GitHub: Unknown):


This got resolved it, would appear.

@ghost ghost added major bug labels Mar 29, 2016
@ghost ghost closed this as completed Mar 29, 2016
jaraco added a commit that referenced this issue Feb 6, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants