Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/downgrade pip #1645

Closed
wants to merge 3 commits into from
Closed

Bugfix/downgrade pip #1645

wants to merge 3 commits into from

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jan 26, 2019

As discussed in #1644, bootstrapping issues have emerged with the pep517 build support in pip 19. This change wraps the 'install' command from tox to ensure that a requisite version of pip is present for builds, unblocking testing/development until a more permanent solution can be devised.

@jaraco
Copy link
Member Author

jaraco commented Jan 26, 2019

As you can see, this patch fails on Windows, due probably to the bin/Scripts disparity or maybe due to the .exe extension.

@jaraco
Copy link
Member Author

jaraco commented Jan 26, 2019

Oh, no. The cause is that pip can't uninstall itself on Windows due to locking of the executable file.

@benoit-pierre
Copy link
Member

I was going to suggest maybe adding setuptools to the build requirements instead, so setuptools can be installed from source with pip>=19.0, but I see that we forget to include pyproject.toml in our source dist...

@jaraco
Copy link
Member Author

jaraco commented Jan 26, 2019

I was going to suggest maybe adding setuptools to the build requirements instead

Actually, that's a very attractive prospect. It's always been a bit messy trying to ascertain 'which' setuptools is present during a build/install of itself. It'd sure be nice to rely on isolation and explicit declaration so that a particular build of setuptools could rely on perhaps a different version (or even build system).

@benoit-pierre
Copy link
Member

benoit-pierre commented Jan 26, 2019

But the command that install setuptools is separate from one to install the dependencies, so this should just work:

 tests/requirements.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git i/tests/requirements.txt w/tests/requirements.txt
index d301168a..f6719728 100644
--- i/tests/requirements.txt
+++ w/tests/requirements.txt
@@ -10,3 +10,4 @@ coverage>=4.5.1
 pytest-cov>=2.5.1
 paver; python_version>="3.6"
 futures; python_version=="2.7"
+pip==18.1

@jaraco
Copy link
Member Author

jaraco commented Jan 26, 2019

Superseded by #1647

@jaraco jaraco closed this Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants