Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting custom TLS CA cert file paths with env vars. #1821

Closed
wants to merge 1 commit into from
Closed

Conversation

hjoukl
Copy link

@hjoukl hjoukl commented Aug 16, 2019

Summary of changes

Respect the SSL_CERT_FILE, REQUESTS_CA_BUNDLE and CURL_CA_BUNDLE env vars,
if set, to allow setting custom TLS CA cert file paths with setuptools'
urllib-based HTTPS implementation in a common fashion.

Closes #1630

(probably also addresses/enables a workaround for #1320)

Pull Request Checklist

  • Changes have tests
  • News fragment added in changelog.d. See documentation for details
  • Changes have documentation

Respect the SSL_CERT_FILE, REQUESTS_CA_BUNDLE and CURL_CA_BUNDLE env vars,
if set, to allow setting custom TLS CA cert file paths with setuptools'
urllib-based HTTPS implementation in a common fashion.

Addresses: #1630, #1320
@jaraco
Copy link
Member

jaraco commented May 24, 2020

Thanks for proposing these changes. Your work here is excellent, with a clean test, clean implementation, and good changelog entry. Unfortunately, some time has passed and in the meantime, #1830 has landed, relying on pip for setup_requires and addressing the issue. If it turns out there are still outstanding cases revealed in #1630 not addressed by #1830, we may want to revisit this change.

@jaraco jaraco closed this May 24, 2020
@hjoukl
Copy link
Author

hjoukl commented Oct 2, 2020

Thanks for the kind words. Much appreciated 🙂!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setuptools fails in corporate MITM proxy with intermediate SSL cacerts
2 participants