-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade setuptools.depends to importlib from depracated imp #1855
Conversation
apparently the error is related with pytest-dev/pytest#2506 |
I'll change the |
All done, it is working as expectedly. No API changed. |
I really hate how entangled these behaviors are... and how messy the code will continue to be even after python 2.7 support is dropped. I've got a patch incoming that I think helps. |
Almost an hour ago, I thought I'd found a solution, but I realized used of I think things are working in that last commit. @isidentical can you review this latest change and in particular explain what the code in _imp._resolve is meant to do? ...and whether it should be called in _imp.get_module? Thanks. |
now it passes py27 tests (a little fix about |
py34 tests are passing (use |
done
when i was testing my initial patch i encountered with a case but i dont think it is needed here. |
Thanks |
Thank you. Change is releasing as v41.6.0. |
This change was implicated in #1896 |
Summary
Fix;
Pull Request Checklist