Make easy_install command less strict (fixes #1405) #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any interest in this PR? According to #1405, there seems to be a consensus about the approach taken here. Since this issue is preventing me from adopting PEP 517/518 projects more widely, I would appreciate some feedback. |
|
I'm interested. Been watching this PR since it was submitted. I don't have much to add other than the current status is quite a hurdle on our project. The tradeoffs for the workarounds are not great. For what is worth PR lgtm. |
|
Thank you very much! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR implements the changes proposed in issue #1405:
--useroption is always available. A warning is issued if the user site directory is not available.PYTHONPATHhas been turned into a warning.Closes #1405
Pull Request Checklist
Discussion
We should probably adapt the message when the install directory is not on
PYTHONPATHsince it is no longer a hard error. Any opinions?Also, this is my first PR for
setuptools, so I am interested in feedback as well as guidance on how/where to implement the tests. WouldTestEasyInstallTestfromsetuptools/tests/test_easy_install.pybe appropriate?