Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reliance on pkg_resources for entry points #3087

Merged
merged 22 commits into from
Feb 12, 2022
Merged

Remove reliance on pkg_resources for entry points #3087

merged 22 commits into from
Feb 12, 2022

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Feb 6, 2022

Ref #3085

jaraco added 18 commits February 6, 2022 11:10
@jaraco
Replaced use of iter_entry_points in setuptools.dist
2d6cc80
@jaraco
Update vendoring for importlib_metadata to support vendored dependenc…
988bf12 
…ies typing_extensions and zipp.
@jaraco
Migrate remainder of 'iter_entry_points' to importlib_metadata.
ff3447a
@jaraco
Avoid dual-use variable.
867147f
@jaraco
Remove duplicate check on ep is None.
282f212
@jaraco
Refactor to construct data in a single expression and extract 'to_str'.
c5f7e3b
@jaraco
Refactor to extract entry_points_definition generation.
d47d356
@jaraco
Extract function for converting entry points to a string.
161ff0f
@jaraco
In egg_info, port use of pkg_resources.EntryPoint to importlib.metadata
b257d13
@jaraco
In test command, rely on metadata.EntryPoint for loading the value.
abf0021
@jaraco
Port check_importable to metadata.EntryPoint
f507f76
@jaraco
Extract module for entry point management.
67b25e3
@jaraco
Prefer jaraco.text for yield_lines.
c49b7d3
@jaraco
Refactor _entry_points to separate loading from rendering. Explicitly…
ebdaa76 
… validate and restore validation of entry points that don't match the pattern.
@jaraco
Use new _entry_points.load to validate entry points.
4e18004
@jaraco
Update test_sdist not to rely on pkg_resources.
1770247
@jaraco
Update changelog.
412d354
@jaraco
Prefer jaraco.text for yield_lines.
740c3b1
@jaraco
Copy link
Member Author

jaraco commented Feb 6, 2022 •
edited
Loading

That's weird. Tests are timing out on PyPy (only). The same thing happens on my local machine.

Curiously, if I disable the pytest-xdist plugin, the tests run. So it seems xdist is implicated.

@jaraco
Copy link
Member Author

jaraco commented Feb 6, 2022

I do see that at least one test passed on pypy for SETUPTOOLS_USE_DISTUTILS=local. I don't get it - there's next to nothing in this change that's related to distutils or pypy.

@jaraco
Copy link
Member Author

jaraco commented Feb 7, 2022

An earlier test is passing or nearly passing. Maybe the issue is transient.

@jaraco jaraco closed this Feb 7, 2022
@jaraco jaraco reopened this Feb 7, 2022
@jaraco
Copy link
Member Author

jaraco commented Feb 7, 2022

Issue was apparently transient. Seems tests are getting flakier and flakier. Not good considering it’s now taking hours to work through jobs.

@abravalheri
Copy link
Contributor

abravalheri commented Feb 7, 2022 •
edited
Loading

Issue was apparently transient. Seems tests are getting flakier and flakier. Not good considering it’s now taking hours to work through jobs.

Yes, I noticed in previous PRs that the combination Windows + PyPy 3.7 is specially flaky. In most of the cases I observed, the error happens on test_build_meta.py with self.pool.submit. For some reason the combination seems to lead to memory allocation errors (lack of available memory in the worker, maybe? That would make sense with the behaviour you observed with xdist). Other time it just takes for ever and ends up cancelled.

These are just a few of the examples I found recently:

@jaraco jaraco merged commit 00fbad0 into main Feb 12, 2022
@jaraco jaraco deleted the debt/remove-pkg-resources branch February 12, 2022 16:58
abravalheri added a commit to abravalheri/setuptools that referenced this pull request Feb 12, 2022
@abravalheri
Add timeout to test_build_meta
b466350 
As discussed in pypa#3087, `test_build_meta` seems to be flaky
specially for the combination of Windows + PyPy.

This is a proposed workaround for such scenarios.
@abravalheri abravalheri mentioned this pull request Feb 12, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaraco @abravalheri @webknjaz