-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix editable --user installs with build isolation #3151
Conversation
af4b241
to
229b0b7
Compare
bed8e80
to
e977837
Compare
Add a new test and confirm that it fails in the expected manner
e977837
to
2e7ba45
Compare
This reverts commit 6376ad1.
This test broke on my machine for some reason
According to https://pypi.org/project/py/, this library is in maintenance mode and should not be used in new code.
Thank you very much for investigating this @hexagonrecursion and providing a fix! I changed a little bit your test code to avoid using directly the |
This approach seems reasonable to me, if the user is explicitly asking for installing in the home, we should honour that. Question: if I understood it correctly we are still keeping the isolation in terms of not allowing libraries installed in the user home to be used during the build, right? (The only thing that changes is that we "break the isolation" just when it is time to install the |
correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @hexagonrecursion, this looks good!
@jaraco ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FTR: the first setuptools release to include this fix is 62.0.0 from 2022-04-04 |
Summary of changes
Make
setup.py develop --user
install to the user site packages directory even if it is disabled in the current interpreter.Closes #3019
Pull Request Checklist
changelog.d/
.(See documentation for details)