Merge PEP 660 implementation into `main` #3488

abravalheri · 2022-08-05T10:06:59Z

The idea of this PR is just to mark the implementation as "complete enough" / "tested enough" that it can be merged into main.

The main concepts of the implementation were presented in #3265.

The development of this feature was split into several PRs previously submitted.
Anyone interested in checking these smaller PRs can have a look on the following searches:

Several discussions and feedback were collected in:

Hopefully the development was slow enough and the community engagement was broad enough that there were enough chances of involvement for feedback, design changes, etc... 🤞

Instructions for testing the feature before the PR is merged can be found in https://discuss.python.org/t/help-testing-pep-660-support-in-setuptools/16904.

Summary of changes

Added editable hooks according with PEP 660
Added a "strict" editable installation mode
Added a "compat" editable installation mode (this mode is transitional and will be removed in future versions of setuptools - my personal suggestion is to remove this mode after the end of the year).
Added mechanisms for custom build sub-commands to tap into the editable install mode and do the necessary adaptions.
Updated userguide/development_mode docs.
Changed build_py and build_ext to add a mechanism of getting a list of files being packages and to which original files they correspond to.
Improved handling of --build-option and --global-option in the config_settings argument of the build_meta hooks (to match the historic pip behaviour)
- this is, at least in theory, backwards compatible and only warn the user when a given --global-option should actually be a --build-option, but accept it anyway.

Closes #2816

Pull Request Checklist

Changes have tests
News fragment added in changelog.d/.
(See documentation for details)

…info

Changes: - Deprecate the --egg-base parameter for dist_info and add --output-dir as replacement (Since the egg format is mostly deprecated, it is nice to move away from this nomenclature...)

Avoid using the editables dependency - The current implementation is using it to simply place .pth file pointing to the project directory anyway... - Adding a dependency for creating a file with a single line is a bit overkill. Avoid importing pkg_resources directly - Setuptools wants to move away from pkg_resources Replace custom wheel build with re-use of bdist_wheel - pro: avoid re-implementing the archiving logic and make sure it is compatible with the same archive format used by the final wheels. - con: the API of wheel is not exactly stable or exported as public.

This change is heavily inspired by the existing develop command - Use namespaces.Installer to ensure legacy namespaces are handled.

- Improve the skeleton that would allow the separation between different editable strategies - Extract strategy for static .pth files - Recognise the static .pth file as the primary strategy for src-layout packages in a "non"-strict scenario

- Move test_editable_prefix from test_develop to test_editable_install - Add more tests for editable install focusing on packages using namespaces (legacy or PEP 420)

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Co-Authored-By: Sean Mooney <work@seanmooney.info> Change-Id: I0fd13f34ddeec25161d63437f2ea14f7b3a4c42e

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488

* Update neutron from branch 'master' to 344baa4d4ba821baa8307c22d4cfe6494b19496c - add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: Iee3338c1dd583fc35d93a3e6e74f8f71b7f076e0

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: Iee3338c1dd583fc35d93a3e6e74f8f71b7f076e0

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: I949ce04599a1945b4535506e361d0dc2a701b775

* Update neutron-lib from branch 'master' to 3a160219ece5dfefa60d6843d4f518f0a313f018 - add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: I949ce04599a1945b4535506e361d0dc2a701b775

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Co-Authored-By: Sean Mooney <work@seanmooney.info> Change-Id: Iebe24254a74a03d388c2ad768f4bc79945047084

* Update heat from branch 'master' to 88027a901b49e7c19d8dd11bd70b51b4c6e8d895 - add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Co-Authored-By: Sean Mooney <work@seanmooney.info> Change-Id: Iebe24254a74a03d388c2ad768f4bc79945047084

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Co-Authored-By: Sean Mooney <work@seanmooney.info> Change-Id: Iab8fe3cf745741496dfde2fe3ae88d6aada8cf28

* Update ceilometermiddleware from branch 'master' to 9cf77fd74228de0d4d6929f1fbfa09c1197be751 - add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Co-Authored-By: Sean Mooney <work@seanmooney.info> Change-Id: Iab8fe3cf745741496dfde2fe3ae88d6aada8cf28

* Update swift from branch 'master' to 43aa7ec26155ccc72d1213b4b9c61c272f607a2a - add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: I82e0c130c4022164bc8e4d1120aae9bdb9a43b5d

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: I82e0c130c4022164bc8e4d1120aae9bdb9a43b5d

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: Ia68aa799a0c4daaffd59c6faa2b59a5dda4015a8

* Update python-watcherclient from branch 'master' to 3fa37f817ea9680a304a7393b1d89aea5761ed9b - add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: Ia68aa799a0c4daaffd59c6faa2b59a5dda4015a8

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: I46d3905209a39fb17c563911b5c0ff1df21f9c4d

* Update watcher-tempest-plugin from branch 'master' to cae42d194c2550b2d44046c9650ef58e2b70a428 - Merge "add pyproject.toml to support pip 23.1" - add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: I46d3905209a39fb17c563911b5c0ff1df21f9c4d

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: I28715183ae9c1f9b75d6d68d6a8a0d554bffd9ce

* Update watcher-dashboard from branch 'master' to 29be9daeccfd462b1be176378cb2ab90bfc584df - Merge "add pyproject.toml to support pip 23.1" - add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: I28715183ae9c1f9b75d6d68d6a8a0d554bffd9ce

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Co-Authored-By: Sean Mooney <work@seanmooney.info> Change-Id: Iabcea21af84e1664030d421561c9d166290dc860

* Update python-aodhclient from branch 'master' to f83e495968d14ac497abdbdc773635e6f9f1f5e5 - Merge "add pyproject.toml to support pip 23.1" - add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Co-Authored-By: Sean Mooney <work@seanmooney.info> Change-Id: Iabcea21af84e1664030d421561c9d166290dc860

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Co-Authored-By: Sean Mooney <work@seanmooney.info> Change-Id: I07ac70065b276aa70eea5d5f1a5a0ac1a94f1242

* Update aodh from branch 'master' to a1be40e05e0cbe450503c7fb187763d5731ec6e6 - Merge "add pyproject.toml to support pip 23.1" - add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Co-Authored-By: Sean Mooney <work@seanmooney.info> Change-Id: I07ac70065b276aa70eea5d5f1a5a0ac1a94f1242

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 addtionally horizon was using a legacy packaging hook which is removed by this commit. Change-Id: I904376f05c2ceca8db9dc989909cb05ea65b79f3

* Update horizon from branch 'master' to d2393c333d74da2f21bab0ec50c2a9274efc2dee - Merge "add pyproject.toml to support pip 23.1" - add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 addtionally horizon was using a legacy packaging hook which is removed by this commit. Change-Id: I904376f05c2ceca8db9dc989909cb05ea65b79f3

* Update ironic-ui from branch 'master' to 488d7003858f18034fcc097bad7be069e2aada38 - Merge "add pyproject.toml to support pip 23.1" - add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Co-Authored-By: Sean Mooney <work@seanmooney.info> Change-Id: I3db53e52556c017111beb7894957be8364fd8164

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Co-Authored-By: Sean Mooney <work@seanmooney.info> Change-Id: I3db53e52556c017111beb7894957be8364fd8164

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Co-Authored-By: Sean Mooney <work@seanmooney.info> Change-Id: Ieeeb059b5d617fe84f60e77defd88a72b5598f0f

* Update networking-sfc from branch 'master' to b7b03bcd34bad6b062853cc745b76b2a6e532144 - Merge "add pyproject.toml to support pip 23.1" - add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Co-Authored-By: Sean Mooney <work@seanmooney.info> Change-Id: Ieeeb059b5d617fe84f60e77defd88a72b5598f0f

pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: I9600d7bf45d48b83c8b066bda20680365bedade7 Signed-off-by: Sean Mooney <work@seanmooney.info>

* Update glance from branch 'master' to 7a21722ecdd349610102ce4ea67705dd0c2c4fb0 - Add pyproject.toml to support pip 23.1 pip 23.1 removed the "setup.py install" fallback for projects that do not have pyproject.toml and now uses a pyproject.toml which is vendored in pip. To address that, this change adds the minimal pyproject.toml to enable pbr to be properly used to build editable wheels. This is required to support installing devstack on centos stream 9 and related distros with GLOBAL_VENV=True Without this change the wsgi scripts are not generated in editable mode. i.e. pip install -e /opt/stack/keystone See https://pip.pypa.io/en/stable/news/#v23-1 and pypa/pip#8368 for more details on the removal of the fallback support. setuptools v64.0.0 is used to support editable installs via its PEP-660 implmentation pypa/setuptools#3488 Change-Id: I9600d7bf45d48b83c8b066bda20680365bedade7 Signed-off-by: Sean Mooney <work@seanmooney.info>

dholth and others added 30 commits February 4, 2022 15:19

include pep660 proof of concept

be3778e

include pep660 proof of concept (#3082)

2bddfdf

Add dist_info_dir param to dist_info command

c6106b7

Change dist_info to better control output directory

ad803ae

Merge branch 'upstream/main' into build-editable-aggregate

e36951e

Change build_meta to use --output-dir instead of --egg-base for dist-…

e55e51d

…info

Make sure output_dir exists with dist_info

1afb6c0

Avoid creating dist_info_dir before the command runs

0e6870b

Fix signature for build_editable according to PEP 660

da6dd05

Fix flake8 errors with build_meta

e7123c6

Add prepare_metadata_for_build_editable hook

821d664

Editable rework dist_info to use --output-dir instead of --egg-base

c642529

Changes: - Deprecate the --egg-base parameter for dist_info and add --output-dir as replacement (Since the egg format is mostly deprecated, it is nice to move away from this nomenclature...)

Remove unecessary editable dependency

5bb97d0

Make sure setuptools itself can be installed with editable_wheel

3e9f441

Rely on wheel and bdist_wheel for editable_wheel

5866b85

Re-use dist-info dir for build_editable

aee3245

Always run editable install test

33f2431

Start adding APIs for handling multiple editable modes

06fbc36

Temporarily support deprecated namespace packages

7b402eb

Remove unused function

a31df2e

Reorganise editable_wheel to allow different strategies

7ae5a69

Handle namespace_packages in editable_wheel

a13adc8

This change is heavily inspired by the existing develop command - Use namespaces.Installer to ensure legacy namespaces are handled.

Rename variable for clarity

14eb855

Add namespace test

8cb1344

Move test from test_develop to test_editable_install

73c65b2

Add test for PEP 420 packages

59a39d9

Add tests for editable install focusing on namespaces

a27b96b

- Move test_editable_prefix from test_develop to test_editable_install - Add more tests for editable install focusing on packages using namespaces (legacy or PEP 420)

Add template for MetaPathFinder that can be used in editable mode

1a531db

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Merge PEP 660 implementation into `main` #3488

Merge PEP 660 implementation into `main` #3488

Uh oh!

abravalheri commented Aug 5, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Merge PEP 660 implementation into main #3488

Merge PEP 660 implementation into main #3488

Uh oh!

Conversation

abravalheri commented Aug 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Pull Request Checklist

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Merge PEP 660 implementation into `main` #3488

Merge PEP 660 implementation into `main` #3488

abravalheri commented Aug 5, 2022 •

edited

Loading