Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle wave of overdue deprecations #4066

Merged
merged 20 commits into from
Nov 20, 2023
Merged

Handle wave of overdue deprecations #4066

merged 20 commits into from
Nov 20, 2023

Commits on Nov 17, 2023

  1. Re-enable deprecation warning enforcement

    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    60e01c7 View commit details
    Browse the repository at this point in the history

  2. Remove deprecation warning from _normalization.best_effort_version

    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    81a3547 View commit details
    Browse the repository at this point in the history

  3. Remove egg_base option from dist_info

    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    7760a7a View commit details
    Browse the repository at this point in the history

  4. Ensure tags generated by egg_info are valid

    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2c96f00 View commit details
    Browse the repository at this point in the history

  5. Remove 'requires' and 'license_file' from setup.cfg 

    A search in
[`grep.app`](https://grep.app/search?q=%5Erequires%5Cs%2A%3D&regexp=true&filter%5Bpath.pattern%5D%5B0%5D=setup.cfg)
suggests that `requires` is not utilised in `setup.cfg`, so it should be safe to remove.

`license_file` is not fundamental to make distributions work, so it
should be safe to remove.
    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    db987aa View commit details
    Browse the repository at this point in the history

  6. Improve explanation of difference between safe_version and best_effor… 

    …t_version
    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    0910084 View commit details
    Browse the repository at this point in the history

  7. Remove deprecation warning for config_settings --global-option 

    This interface is not super stable/usable yet, so it should be fine
to remove.
    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e247d21 View commit details
    Browse the repository at this point in the history

  8. Remove deprecation warning for invalid versions in setuptools.dist 

    … and post-pone deprecations for `setup.cfg` regarding hifens instead of
underscores and upper-cased fields.
    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    9433e90 View commit details
    Browse the repository at this point in the history

  9. Add news fragments

    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    6cc69fe View commit details
    Browse the repository at this point in the history

  10. Xfail on deprecated bdist_rpm tests

    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    4f60770 View commit details
    Browse the repository at this point in the history

  11. Be strict on missing 'dynamic' in pyproject.toml

    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e4b6fc9 View commit details
    Browse the repository at this point in the history

  12. Enforce namespace-packages are not used in pyproject.toml

    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    9c35cd9 View commit details
    Browse the repository at this point in the history

  13. Use custom class for InvalidConfigError 

    This way we don't have to see `DistutilsOptionError` in the error
message.
    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    4a34a1c View commit details
    Browse the repository at this point in the history

  14. Add newsfragments for latest removals

    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b44faba View commit details
    Browse the repository at this point in the history

  15. Update newsfragments

    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b802c1b View commit details
    Browse the repository at this point in the history

  16. Fix lint errors

    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b243818 View commit details
    Browse the repository at this point in the history

  17. Add workaround for unreleased PyNaCl

    @abravalheri
    abravalheri committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b97814a View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Use InvalidConfigError instead of ValueError in build_meta

    @abravalheri
    abravalheri committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    7c111b8 View commit details
    Browse the repository at this point in the history

  2. Remove deprecated handling of build-option passed as global-option

    @abravalheri
    abravalheri committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    f431962 View commit details
    Browse the repository at this point in the history

  3. Relax validation of --global-option in build_meta 

    In `pip` docs, the following example is mentioned:

> python -m pip wheel --global-option bdist_ext --global-option -DFOO wheel

Since both `--global-option` and `--build-option` are supposed to be
compatible with `pip` options, we should not prevent this abuse...
(Although it is still error prone and the user is responsible for
understanding in detail what is going on how this accidentally works).
    @abravalheri
    abravalheri committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    a5a7505 View commit details
    Browse the repository at this point in the history