Only pass --build-option to bdist_wheel in build_meta
#4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
force-pushed
the
build_meta-arbitrary_args
branch
from
5c7e61d
to
0335364
Compare
|
There was not much feedback on this proposal, so it might be the case people don't feel strong about it. I think I will go ahead with this change because we had one positive feedback from one of pip's maintainers. |
In pypa#2491 (comment) the discussion seems to lead to the idea that it is better for now to avoid passing any `--build-option` for commands that are not `bdist_wheel` in `setuptools.build_meta`.
abravalheri
force-pushed
the
build_meta-arbitrary_args
branch
from
0335364
to
b599a45
Compare
This was referenced Feb 13, 2024
|
This appears to have broken the ability to pass arguments to |
javajawa
added a commit
to mewbotorg/mewbot
that referenced
this pull request
Feb 27, 2024
Fix argument order of --config-settings["--build-option"] arguments. This was broken by pypa/setuptools#4079
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2491 (comment) the discussion seems to lead to the idea that it is better for now to avoid passing any
--build-optionfor commands that are notbdist_wheelinsetuptools.build_meta.Summary of changes
config_settings["--build-option"]tobdist_wheelinsetuptools.build_metaconfig_settings["--build-option"]andconfig_settings["--global-option"]and editable installsPull Request Checklist
newsfragments/.(See documentation for details)