Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python < 3.8 (3.2 to 3.7) obsolete code and comments #4096
Update Python < 3.8 (3.2 to 3.7) obsolete code and comments #4096
Changes from 2 commits
d97640a
7620221
f593095
f559d65
10938cf
dc5dee8
bfae7be
6a744c5
b05644e
de16d24
99cfb83
eba64db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issue/reason to use
importlib_metadata
for Python older than 3.10 is python/importlib_metadata#396 ? Is that something we want to mention?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other reasons too - basically for early adoption of any behavior that was added to
importlib_metadata
but isn't yet in the supported Pythons. Still, that seems like something forcpython
/importlib_metadata
to advertise.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FileExistsError
added in Python 3.3There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source: https://docs.python.org/3/library/sys.html#sys.abiflags + tested on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source: https://docs.python.org/3/library/sys.html#sys.platlibdir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically a revert of b7b9cb2
Unless this still happens in newer versions, in which case the comment should be updated instead.