Prevent a TypeError in compat.py311.shutil_rmtree
#4382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
shutil-rmtree-None-onexc
branch
from
531722b to
0832489
Compare
abravalheri
reviewed
May 24, 2024
Avasam
commented
May 24, 2024
Avasam
commented
May 24, 2024
Comment on lines
+5
to
+8
| from typing import Any, Callable, TYPE_CHECKING | ||
|
|
||
| if TYPE_CHECKING: | ||
| from _typeshed import StrOrBytesPath, ExcInfo |
There was a problem hiding this comment.
Is there anyway we can simplify this?
The runtime fix is just the added conditional. Everything else is type hints.
I just combined imports. I could omit annotating the internal function and move StrOrBytesPath to a runtime alias with StrPath in setuptools._path.
Avasam
force-pushed
the
shutil-rmtree-None-onexc
branch
from
5b9d6c7 to
040ea9e
Compare
…rmtree`is called without an`onexc`` parameter on Python<=3.11
Avasam
force-pushed
the
shutil-rmtree-None-onexc
branch
from
040ea9e to
6e4cf9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Noticed while adding pyright checks to setuptools (#4192)
Also typed
shutil_rmtree(xref python/typeshed#12002 )Pull Request Checklist
newsfragments/.(See documentation for details)