Skip to content

easy_install.get_win_launcher: Default to pythonw.exe in GUI mode #4945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hmartinez82
Copy link

Summary of changes

When creating a launcher script where no explicit python binary is defined, pythonw.exe should be used in Windows when in GUI mode.

Pull Request Checklist

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
hmartinez82 Hernan Martinez
@jaraco
Copy link
Member

jaraco commented Apr 27, 2025

Thanks for the contrib. It does seem like a reasonable change.

Nevertheless, I don't think there's any life left in easy_install or the script launchers. These installers are deprecated and unsupported except for critical security updates. Moreover, any changes to the launcher will require a rebuild of the script launchers, and I'm not even sure if that's possible these days.

I don't plan to merge this, but if you could tell us what motivated this change, it would be good to document, in case it affects others with the same use-case.

@hmartinez82
Copy link
Author

hmartinez82 commented Apr 27, 2025

@jaraco The last file in this PR shows why https://github.com/msys2/MINGW-packages/pull/23966/files . We kept getting a console window when opening Meld, but it's a Gui app. No need to have a console opening in the back :)

The workaround was to hack the file away after it was generated by easy_install.

@jaraco
Copy link
Member

jaraco commented Apr 27, 2025

Thanks for the clarification. Since easy_install is being actively removed, I believe this issue is moot. Glad there's a suitable workaround. A better workaround would be to use build/pip/uv to build/install packages and rely on the scripts they provide.

@jaraco jaraco closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants